AvalonDock Work Item Rss Feed

Created Issue: Need the ability to save the selected item in all the panes [9207]

sg — Tue, 17 Nov 2009 22:17:28 GMT

Need the ability to save the selected item in all the panes

Created Issue: DockingManager.UpdateAnchorStyle for Tiling [9206]

sg — Tue, 17 Nov 2009 18:34:15 GMT

Hi,

I have a requirement to be able to tile my windows (with DockableContent) and I have class derived from DockingManager to add the tiling functionality. What I need is to be able to call DockingManager.UpdateAnchorStyle which is not protected. Can this be made protected?

I also need DockingManager.RegisterFloatingWindow but if you agree that this function should be called from within DockableFloatingWindow's constructor (another issue that I raised), then I am all set. Otherwise can this one be made protected?

Thanks,
sg.

Created Issue: FlyoutDockablePane OnClose when HideOnClose is set to false [9205]

sg — Tue, 17 Nov 2009 18:25:28 GMT

Error when I do the following:
1. Dock a window(DockableFloatingWindow) to one side of the main window
2. Unpin the above window which converts it into a FlyoutDockablePane shown in a FlyoutPaneWindow
3. Hover the mouse over the tab to see the flyout
4. Without pinning it back, click on Close.
Error: The DockableContent is removed but the flyout is still open.

I added the following code to FlyoutDockablePane:

internal override void CloseOrHide(DockableContent cntToCloseOrHide, bool force)
{
base.CloseOrHide(cntToCloseOrHide, force);

if (cntToCloseOrHide.State == DockableContentState.AutoHide)
{
GetManager().HideAutoHideWindow();
GetManager().RemoveContentFromTabGroup(cntToCloseOrHide);
}
}

The HideAutoHideWindow and the RemoveContentFromTabGroup methods have to be made public in DockingManager

Thanks,
sg.

Created Issue: New dockable floating window not in DockingManager.FloatingWindows [9199]

sg — Tue, 17 Nov 2009 13:44:20 GMT

Hi,

When I create a new DockableFloatingWindow using the following code:

DockableFloatingWindow floatingWindow = new DockableFloatingWindow(_dockingManager, _derivedDockableContent);
_derivedDockableContent.SetAsActive();
_derivedDockableContent.Show();

The floatingwindow is not added to the FloatingWindows collection of the DockingManager. Either the constructor of DockableFloatingWindow should get updated or RegisterFloatingWindow be made public.

Thanks,
sg

Commented Issue: Docking Control stealing focus (prevents Command Bindings from working) [6340]

sacchawla — Thu, 12 Nov 2009 04:12:49 GMT

I'm working with another 3rd party control (Xceed's DataGrid) to try and deal with an issue with command bindings not working properly on their grid. Please see related thread here: http://xceed.com/CS/forums/thread/15761.aspx

We have a DataGrid inside a UserControl which is inside an AvalonDock document pane (as the DocumentContent). With this configuration, CommandBindings fail to work from the DataGrid. I submitted a sample to Xceed's support and they looked at the code. They seem to think that issue is within AvalonDock "stealing" focus, which prevents CanExecute from ever being called.

I will upload the same project file to you, that I uploaded to them. Here are the steps to reproduce the problem:

1) Build and run solution
2) Select a row in the DataGrid
3) Right click on the selected row

Expected Result: Menu item should be enabled
Actual Result: Menu item is disabled (CanExecute not called).

Do you think you can please look at this and see if you see what's going on? The DockingControl seems to be preventing all CommandBindings from working on the DataGrid. Due to a licensing issue, you may have to install the (free) trial of Xceed's DataGrid for WPF to be able to run the attached solution: http://xceed.com/pages/TopMenu/Downloads/Trials.aspx?Lang=EN-CA

We would really appreciate any help you can give us to track down this issue. Thanks.

Commented Issue: Problem with some collection [9070]

SimonDullingham — Mon, 09 Nov 2009 20:16:48 GMT

Hi!
I found a problem with latest implementation (1.2.2643): I use VS2010b2, compiled AvalonDock from sources and my own application with dock windows (both, DockableContent & DocumentContent). After start and playing some time with docking I receive InvalidOperationException in DockingManager.cs (see pic). This is how I create DocumentContent programmatically:

var w = new DocContForm() { Title = "New doc" };
dockManager.MainDocumentPane.Items.Add(w);

And this is how I make DockableContent:

dockManager.Show(new MyDockContForm());

Probably, something wrong here?

Created Issue: Closed documents not released for garbage collection [9113]

yem583 — Tue, 03 Nov 2009 21:14:12 GMT

If I run the Window4.xaml sample from the avalondock-45809 build and perform the follow steps.

1. Click Add Documents (Adds 5 DemoDocuments to bound Observable collection)
- take memory snapshot using .Net Memory Profile verify 5 instances of DemoDocument

2. Close Document 0 via the context menu)
- take memory snapshot using .Net Memory Profile verify 5 instances still remaining of DemoDocument

3. Subsequent closes result in removal of instances of DemoDocuments as expected, so that when I have removed all 5 DemoDocuments, I still have 1 Instance remaining.

4. Click Add document a second time
- take a memory snapshot using .Net Memory Profile, now I have 6 instances of DemoDocument in memory but only 5 in view

I can do this repeatedly and app will continue to use up memory

Created Issue: An unspecified error occurred on the render thread. [9105]

dejanberic — Mon, 02 Nov 2009 15:32:42 GMT

To get the the message "An unspecified error occurred on the render thread." do the following.
1) Start AvalonTest.
2) Add 5 documents by clicking the link "Add documents"
3) By using the mouse cursor select Document3
4) Press Ctrl+Tab to switch to Document2
5) Again, press Ctrl+Tab to switch to Document2
The error occurred.

If I comment out the code in the NavigatorWindow.cs then the error disappears.

protected override void OnClosed(EventArgs e)
{
//reset documents list to avoid WPF Bug:
//http://social.msdn.microsoft.com/forums/en/wpf/thread/f3fc5b7e-e035-4821-908c-b6c07e5c7042/
//http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=321955
Documents = new List<NavigatorWindowDocumentItem>();

base.OnClosed(e);
}

The code above apparently resolves the error but I think it actually produces the error.

This error does not occur when using Shift+Tab!

Cheers

Created Issue: Ctrl+Tab not displaying content [9100]

dejanberic — Mon, 02 Nov 2009 15:02:23 GMT

When I use Ctrl+Tab to shift between the documents the content is not displayed. You can see in the example that I attached. It's mainly black. Oddly enough only the ActiveDocument is displayed correctly.
I have established why it doesn't display the content. Because the content's Width and Height is NaN. But I don't know why It displays ActiveDocument.
I have made a patch where I remeber the current Width and Height and replace them with ActualWitdh and ActualHeight. On deactivating the NavigatorWindow I return the original Width and Height.
The same problem is happening with Shift+Tab.
I am using DocumentsSource so I don't know if anything has to do with this.
I will upload a patch.

Created Issue: DockableContent bug [9099]

krokodajl — Mon, 02 Nov 2009 13:09:45 GMT

Hi

I have downloaded latest version from this site: http://avalondock.codeplex.com/SourceControl/ListDownloadableCommits.aspx
Now go to the AvalonDockTest3 (Window3.xaml). In my procject I have removed <ad:DocumentPane Visibility="Visible"/> line. So there is only two DockableContents.
Until these two contents are in one column everything is ok - I can close both. But when I place them in one row (side by side) after closing both of them something strange happens - there is smoething similar to DockableContent but when I am trying to close it I am getting an error.

How this problem can be solved?

Created Issue: Refreshing issue when moving a DockableWindow over a WinFormsHost [9096]

dejanberic — Mon, 02 Nov 2009 07:57:23 GMT

When my DockableWindow (FloatingWindow) is large and I move it over the WinFormsHost, the rendering of a FloatingWindow lags and displays a trail. When I resolved that issue with calling UpdateWindow in the OnDragOver in DockingManager.cs I have another issue.
Now, the window that I'm moving is not refreshed accordingly when the window boundaries gets outside of the whole screen. You can look at the samples that I have attached to see this behavior.
I have resolved this issue with another UpdateWindow in Move method in DragPaneServices.cs.
Will be posting a patch.

Created Issue: Performance issues when moving a splitter when ManagedContent contains WinFormsHost [9095]

dejanberic — Mon, 02 Nov 2009 07:41:35 GMT

Hi. I have noticed that if a ManagedContent contains a WinFormsHost, and that WinFormsHost contains some complex objects that needs to be rendered, the resizing (moving splitters of resizing pane) is extremely slow and lags behind a mouse cursor.
I have corrected this and will be posting a patch.
The patch consists of just replacing this
if (childCtrl != null)
{
childCtrl.CallMethod("Refresh", null);
}

wiht this

if (childCtrl != null)
{
this.Dispatcher.Invoke(new Action<object>((o) => o.CallMethod("Refresh", null)), DispatcherPriority.Render, childCtrl);
}

Now the there is no lag and slowness when moving splitters.

Created Issue: Commands automatically disabled for Floating Window [9086]

Chuck1411 — Sat, 31 Oct 2009 22:22:30 GMT

I have a window that contains a WPF ListView control. The Items in it have a context menu, and the commands within are automatically disabled when the window is floated. Their CanExecute Handlers never get called. But docked, everything works perfectly.

Commented Issue: FloatingWindow.EnableXButton()/DisableXButton() are not implemented correctly [9081]

miniak — Sat, 31 Oct 2009 16:43:00 GMT

MF_BYCOMMAND & SC_CLOSE should be used to avoid hard-coded item positions.
The current implementation using GetMenuItemCount & MF_BYPOSITION does not work as it can be seen in the AvalonDock demo application.

See the attached patch
Comments: ** Comment from web user: miniak **

This is the correct patch file, sorry for the mistake

Created Issue: FloatingWindow.EnableXButton()/DisableXButton() are not implemented correctly [9081]

miniak — Sat, 31 Oct 2009 16:35:49 GMT

Commented Issue: Exception when closing DocumentContents in DocumentsSource [8997]

dejanberic — Thu, 29 Oct 2009 16:01:20 GMT

If I have xaml like this:
<ad:DockingManager x:Name="_dockingManager" RequestDocumentClose="DockingManager_RequestDocumentClose">
<ad:ResizingPanel Orientation="Vertical">
<ad:DocumentPane x:Name="mainTabPanel"/>
</ad:ResizingPanel>
</ad:DockingManager>

and in My cs file I have this:

private ObservableCollection<DocumentContent> documents;

public ObservableCollection<DocumentContent> Documents
{
get { return documents; }
set { documents = value; }
}

public Demo()
{
InitializeComponent();
this.documents = new ObservableCollection<DocumentContent>();
this._dockingManager.DocumentsSource = this.documents;
...
and when I try to clear DocumentsSource to close all Documents like this

this.Documents.Clear();

none of the Documents closes or disappears.
Now, when I try to close Documents one by one like this:
while (this.documents.Count > 0)
{
this.documents.RemoveAt(0);//this is the same as this.documents[0].Close()
}

I get an exception, but in some very specific case. When I make three documentcontents, and then when I right click on the last document and make a New Vertical Tab, then I right click on a second document and make a New Horizontal Tab. and then when I try to
close all the documents in a way that is described above I get an exception. The thing is, when I try to close all the document in such an order that the first documents that are being closed are in MainDocumentPane then I get an exception.
So, to avoid an exception I have to close all documents like this:

public void CloseAllTabItems()
{
////workaround for avalon dock bug, to close all items you must first close those items that do not belong to MainDocumentPane
ObservableCollection<DocumentContentViewItem> documentsToClose = new ObservableCollection<DocumentContentViewItem>();

foreach (DocumentContentViewItem tabItem in this.documents)
{
if (tabItem.Parent is DocumentPane)
{
if ((tabItem.Parent as DocumentPane).IsMainDocumentPane == false)
{
documentsToClose.Add(tabItem);
}
}
}

foreach (DocumentContentViewItem tabItem in documentsToClose)
{
tabItem.Close();
}

while (this.documents.Count > 0)
{
this.documents[0].Close();
}
}

I hope that someone will be able to resolve this bug.
Comments: ** Comment from web user: dejanberic **

Well, now I have changed my code above to support closing and closed events. Simply instead internalClose(0 method write Close(), and in the Close() method of DocumentContent comment out the lines described below

public bool Close()
{

//if documents are attached to an external source via DockingManager.DocumentsSource
//let application host handle the document closing by itself
/*if (Manager.DocumentsSource != null)
{
return Manager.FireRequestDocumentCloseEvent(this);
}*/

CancelEventArgs e = new CancelEventArgs(false);
OnClosing(e);
...
I have absolutely no idea to what purpose is there RequestDocumentCloseEvent because we can attach to closing event or closed event of documentContent and remove the content from DocumentsSource.

Cheers

Created Issue: Problem with some collection [9070]

Vincent3000 — Thu, 29 Oct 2009 06:53:39 GMT

Commented Issue: GetMainDocumentPane(ResizingPanel) snatches my first DockablePane [9018]

dejanberic — Thu, 22 Oct 2009 07:57:26 GMT

Hi!
First up, thanks again for a wonderful docking library.

Secondly I´ve run into a problem since I downloaded the 44904 changeset.
I´ve got this following xaml (might contain some minor miswrite since i needed to change some names due to secrecy):

<avalon:DockingManager x:Name="_dockingManager">
<avalon:ResizingPanel Orientation="Horizontal">
<avalon:ResizingPanel Orientation="Vertical">
<avalon:DockablePane>
<Windows:PackageListWindow x:Name="_packages" Title="Packages"/>
</avalon:DockablePane>
<avalon:DockablePane>
<Windows:PropertyWindow x:Name="_properties" Title="Properties"/>
</avalon:DockablePane>
<avalon:DockablePane>
<Windows:ResultsWindow x:Name="_results"></Windows:ResultsWindow>
</avalon:DockablePane>
</avalon:ResizingPanel>
<avalon:DocumentPane>
<Windows:WelcomeWindow Title="Welcome" x:Name="_welcome" />
</avalon:DocumentPane>
</avalon:ResizingPanel>
</avalon:DockingManager>

Then the problem is that when the UpdateAnchorStyle is called on the main ResizingPanel the following row (DockingManager:2041):
if (!foundDocumentContent && GetMainDocumentPane(child as ResizingPanel) != null)
calls the GetMainDocumentPane, this will take my first DockablePane and assign it as the main DocumentPane using the following code:

if (child is DockablePane)
{
DocumentPane doc = new DocumentPane();
DockablePane dockablePane = child as DockablePane;
while (dockablePane.Items.Count > 0)
{
doc.Items.Add((dockablePane.Items[0] as DockableContent).DetachFromContainerPane());
}
return doc;
}

As a temp fix i've just commented this out but perhaps this finding of a main document pane should only be done if no documentpane is specified within the xaml (which it is in my case)?
Don't know the purpose of this code so I couldn't give a solution to fix but perhaps this could give some direction to whereas the problem lies?

Best Regards
Comments: ** Comment from web user: dejanberic **

OK, I made that patch to avoid exception that I was getting when restoring a layout. It looks like I wasn't taking care of other implications the code brings with it. The problem I had was described here http://avalondock.codeplex.com/WorkItem/View.aspx?WorkItemId=8975.

So it looks like that we should not allow for dockable contents that is primarily located in dockable pane to dock in to the DocumentPane. That should solve both of our problems.
If I dock my dockable contents from dockable pane to documentpane and save the layout, in the layout file my DockableContent is placed inside a DocumentPanePlaceHolder and when restoring a layout it appears to be located in a dockablePane like is described in xaml file hence no main document pane could be set thus the exception occurs.

Created Issue: GetMainDocumentPane(ResizingPanel) snatches my first DockablePane [9018]

Almund — Wed, 21 Oct 2009 19:47:41 GMT

Created Issue: Dock to top programmatically failed to set the default height [9016]

newpingpong — Wed, 21 Oct 2009 02:20:15 GMT

In order to reproduce the issue, we can create a window as below,

<Window ...>
<Grid>
<ad:DockingManager x:Name="dockManager">
<ad:DocumentPane />
</ad:DockingManager>
</Grid>
</Window>

In the code behind, we hook up to the Loaded event to dock an dockable content (e.g. ToolBoxWindow) to the top/bottom border,

void Window_Loaded(object sender, RoutedEventArgs e)
{
ToolBoxWindow toolBoxWnd = new ToolBoxWindow() { Title = "Toolbox" } // DockableContent-derived user control

dockManager.Show(toolBoxWnd, DockableContentState.Docked, AnchorStyle.Top);
}

The ToolBoxWindow is actually created and docked to the top border, but its height is set to 0, we need to use the splitter to enlarge it.

After debugging, I found out that the issue may be caused by a segment of code used to set the default height/width of the DockablePane of the DockingManager.Show method

DockablePane dockParent = content.ContainerPane as DockablePane;
if (content.ActualWidth == 0.0 && (
dockParent.Anchor == AnchorStyle.Left || dockParent.Anchor == AnchorStyle.Right))
{
ResizingPanel.SetResizeWidth(dockParent, new GridLength(200));
ResizingPanel.SetEffectiveSize(dockParent, new Size(200, 0.0));
}
else if (content.ActualWidth == 0.0 && (
dockParent.Anchor == AnchorStyle.Left || dockParent.Anchor == AnchorStyle.Right))
{
ResizingPanel.SetResizeWidth(dockParent, new GridLength(200));
ResizingPanel.SetEffectiveSize(dockParent, new Size(200, 0.0));
}

This should be rewritten as below,

DockablePane dockParent = content.ContainerPane as DockablePane;
if (content.ActualWidth == 0.0 && (
dockParent.Anchor == AnchorStyle.Left || dockParent.Anchor == AnchorStyle.Right))
{
ResizingPanel.SetResizeWidth(dockParent, new GridLength(200));
ResizingPanel.SetEffectiveSize(dockParent, new Size(200, 0.0));
}
else if (content.ActualHeight == 0.0 && (
dockParent.Anchor == AnchorStyle.Top || dockParent.Anchor == AnchorStyle.Bottom))
{
ResizingPanel.SetResizeHeight(dockParent, new GridLength(200));
ResizingPanel.SetEffectiveSize(dockParent, new Size(0.0, 200));
}